Adjust testclient typing and warnings#3322
Merged
Kludex merged 5 commits intoJun 10, 2026
Merged
Conversation
There was a problem hiding this comment.
No issues found across 1 file
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
Kludex
reviewed
Jun 10, 2026
| "You should not use the 'timeout' argument with the TestClient. " | ||
| "See https://github.com/Kludex/starlette/issues/1108 for more information.", | ||
| DeprecationWarning, | ||
| stacklevel=2, |
Kludex
reviewed
Jun 10, 2026
| "You can install this with:\n" | ||
| " $ pip install httpx2\n" | ||
| ) | ||
| ) from None |
Kludex
reviewed
Jun 10, 2026
Kludex
left a comment
Owner
There was a problem hiding this comment.
The rest that I didn't mark as "This makes sense" I don't think makes sense.
…ent-typing-warnings-20260607
…m:waketzheng/starlette into codex/testclient-typing-warnings-20260607
Contributor
Author
|
@Kludex Updated. |
Kludex
approved these changes
Jun 10, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selfimport behindTYPE_CHECKINGintestclientTestClienttimeout deprecation warningsModuleNotFoundErrorchain whenhttpx2/httpxis missingWebSocketTestSession.__enter__typed asSelfChecklist