Handle empty example test collection in CI - #342
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
sylvesterkaczmarek
marked this pull request as ready for review
August 15, 2026 11:11
Collaborator
|
This looks good to me, but something seems to be blocking the merge, I'm not sure what the issue is. I'll ask around.. |
jzleibo
previously approved these changes
Aug 16, 2026
Contributor
Author
|
Hi @jzleibo, just a quick follow-up on this. You mentioned you'd ask around about what was blocking the merge. The visible checks on the current head are all green and the PR is still mergeable from GitHub's side. Have you heard anything about the remaining blocker? Thanks again for taking a look. |
sylvesterkaczmarek
force-pushed
the
fix/skip-rllib-without-optional-deps
branch
from
August 23, 2026 13:36
f2e19bc to
6486ad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the
test-examplesworkflow green whenexamples/currently contains no pytest tests, while still running example tests when they exist.The original failure reported in #316 involved the now-removed Gym/RLlib examples. Those directories were removed from
main, but the workflow still runspytest examples. On currentmain, pytest collects zero tests and exits with status 5, causingtest-examplesto fail for otherwise unrelated pull requests.This change:
pytest examplesNO_TESTS_COLLECTED) as successFixes #316.
Validation
Rebased onto current
mainas a single focused commit (6486ad478df064f16fa3443a3f7babfb889c1d28).GitHub Actions on the rebased head:
test-examples: passedThe final diff changes only
.github/workflows/test-examples.ymlwith 10 additions and 1 deletion.