Repository navigation
Add test for ntpath.expanduser #65692
Description
| BPO | 21493 |
|---|---|
| Nosy | @PCManticore, @serhiy-storchaka |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-05-28.15:39:31.309>
created_at = <Date 2014-05-13.10:12:40.242>
labels = ['type-feature', 'tests']
title = 'Add test for ntpath.expanduser'
updated_at = <Date 2014-05-28.15:39:31.292>
user = 'https://github.com/PCManticore'bugs.python.org fields:
activity = <Date 2014-05-28.15:39:31.292>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-05-28.15:39:31.309>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2014-05-13.10:12:40.242>
creator = 'Claudiu.Popa'
dependencies = []
files = ['35239', '35355']
hgrepos = []
issue_num = 21493
keywords = ['patch']
message_count = 5.0
messages = ['218427', '219102', '219104', '219275', '219279']
nosy_count = 3.0
nosy_names = ['Claudiu.Popa', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21493'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
Activity
PCManticore commentedon May 13, 2014
Hello. This patch adds a test for ntpath.expanduser, which was missing. Also, it increases the test coverage for ntpath.py from 68% to 75%.
serhiy-storchaka commentedon May 25, 2014
LGTM. But most other tests in this file use tester() to test str and bytes. And it would be good to test multicomponent arguments (e.g. '~test\\foo\\bar' and '~/foo/bar').
PCManticore commentedon May 25, 2014
Here's an updated patch.
python-dev commentedon May 28, 2014
New changeset 5e599b301ebd by Serhiy Storchaka in branch '2.7':
Issue bpo-21493: Added test for ntpath.expanduser(). Original patch by
http://hg.python.org/cpython/rev/5e599b301ebd
New changeset a981a088512c by Serhiy Storchaka in branch '3.4':
Issue bpo-21493: Added test for ntpath.expanduser(). Original patch by
http://hg.python.org/cpython/rev/a981a088512c
New changeset 5a71a7e60fe6 by Serhiy Storchaka in branch 'default':
Issue bpo-21493: Added test for ntpath.expanduser(). Original patch by
http://hg.python.org/cpython/rev/5a71a7e60fe6
serhiy-storchaka commentedon May 28, 2014
Thanks Claudiu.