Preserve terminal observation in BraxAutoResetWrapper for correct truncation bootstrapping - #351
Open
andreolf wants to merge 1 commit into
Open
Conversation
…d#305) BraxAutoResetWrapper overwrote state.obs with the reset observation on done without keeping the terminal (pre-reset) obs anywhere, making correct value bootstrapping on truncation impossible for downstream RL. Expose it in state.info['AutoResetWrapper_final_obs'] (initialized in reset() for pytree consistency, set in step()). Extends the existing wrapper test.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #305.
BraxAutoResetWrapperoverwrotestate.obswith the reset observation ondonewithout preserving the terminal (pre-reset) observation anywhere, which makes correct value bootstrapping on truncation impossible for downstream RL (every actor-critic method needs the terminal obs to distinguish termination from truncation when computing TD/GAE targets — the same reason Gymnasium exposesfinal_observation).Change
state.info['AutoResetWrapper_final_obs'].step()from the true post-stepstate.obs(before it's blended with the reset obs).reset()so theinfopytree structure matchesstep()(important underjax.lax.scan).test_auto_reset_wrapperto assert the key exists after reset and that, on a done step, the preserved terminal obs differs from the returned reset obs.Non-breaking: only adds a new
infokey.Notes
wrapper_test.py. The change is small and mirrors the existing*_first_obsbookkeeping.